Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

addons(ethtool): Add --set-channels option #268

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

addons(ethtool): Add --set-channels option #268

wants to merge 1 commit into from

Conversation

tomvil
Copy link
Contributor

@tomvil tomvil commented Jul 31, 2023 

auto ens10f0
iface ens10f0 inet static
    channels-rx 0
    channels-tx 0
    channels-combined max

root@test:~# ethtool -l ens10f0
Channel parameters for ens10f0:
Pre-set maximums:
RX:		64
TX:		64
Other:		n/a
Combined:	64
Current hardware settings:
RX:		0
TX:		0
Other:		n/a
Combined:	64

@julienfortin julienfortin self-assigned this Jul 31, 2023
@tomvil
Copy link
Contributor Author

tomvil commented Mar 5, 2024

@julienfortin It has been a while 😄 will you merge this or should I close it?

@julienfortin
Copy link
Contributor

Hi, you can leave it open. I haven't tested it yet but it looks okay. Overall i'm not a fan of if elif elif elif and the ways things are done today in the ethtool module, seems very slow to run all those commands all the time.
I'll make a debian upload before summer and will merge this before.

@sohorx
Copy link
Contributor

sohorx commented Jul 29, 2024

Hi,

Interestingly enough, I did add set/get channels functions to the pyroute2 ethtool interface a few months ago: svinota/pyroute2#1192.

And, as I found this PR, I was wondering why ifupdown2 is not using pyroute2 in many cases. @julienfortin , is it intentional to avoid making pyroute2 a dependency ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@julienfortin julienfortin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tomvil @julienfortin @sohorx